Skip to content

Improve/revisit _setup_collect_fakemodule#279

Merged
blueyed merged 12 commits intomy-masterfrom
mm-rm-_setup_collect_fakemodule
Mar 12, 2020
Merged

Improve/revisit _setup_collect_fakemodule#279
blueyed merged 12 commits intomy-masterfrom
mm-rm-_setup_collect_fakemodule

Conversation

@blueyed
Copy link
Owner

@blueyed blueyed commented Mar 11, 2020

Upstream: pytest-dev#6803

blueyed added 10 commits March 12, 2020 12:02
Make it a real module instead.

This was initially added in 9b58d6e
(pytest-dev#2315), when removing support
for `pytest_namespace`.

Not sure if it ever worked "properly", but currently
`import pytest.collect` and `from pytest.collect import File` do not
work (but with this patch).

This is only relevant for (backward) compatibility, but the more it
appears to make sense to move it into a lazily loaded, separate file.
Taken out of pytest-dev#6733, returning
for existing symlink (should not skip).
@blueyed blueyed force-pushed the mm-rm-_setup_collect_fakemodule branch from da6e88a to a257a12 Compare March 12, 2020 11:02
@blueyed blueyed force-pushed the mm-rm-_setup_collect_fakemodule branch from 1c96433 to e43a2f7 Compare March 12, 2020 11:52
@blueyed blueyed merged commit 814616d into my-master Mar 12, 2020
@blueyed blueyed deleted the mm-rm-_setup_collect_fakemodule branch March 12, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant