pytester: use global monkeypatch fixture#78
Merged
Conversation
blueyed
force-pushed
the
pytester-monkeypatch
branch
from
f5facf6 to
c9e8e9f
Compare
The update for inner runs then respects values being set there, e.g. `COLUMNS`. It also sets `COLUMNS` only for inner runs - otherwise the outer pytest's `_write_progress_information_filling_space` would use the terminal width from inner runs etc (since it is used before the teardown finalizer that unsets it).
blueyed
force-pushed
the
pytester-monkeypatch
branch
from
c9e8e9f to
36e8c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update for inner runs then respects values being set there, e.g.
COLUMNS.It also sets
COLUMNSonly for inner runs - otherwise the outer pytest's_write_progress_information_filling_spacewould use the terminal widthfrom inner runs etc (since it is used before the teardown finalizer that
unsets it).