Replace bmad-init dependency with direct config loading#32
Conversation
Both agent-builder and workflow-builder skills now load config
directly from {project-root}/_bmad/bmb/config.yaml instead of
invoking the bmad-init skill, making them self-contained.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughBoth skill documentation files replace the previous initialization method that invoked the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Updates the agent/workflow builder skills to load module configuration directly from 🤖 Was this summary useful? React with 👍 or 👎 |
| ## On Activation | ||
|
|
||
| 1. Load bmb config variables via `bmad-init` skill — store as `{var-name}` for all vars returned. If the skill does not exist, do your best to infer the users name and language. Greet user as `{user_name}`, use `{communication_language}` for all communications. | ||
| 1. Load config from `{project-root}/_bmad/bmb/config.yaml` and resolve: |
There was a problem hiding this comment.
Since bmad-init is no longer invoked, what should the skill do if {project-root}/_bmad/bmb/config.yaml is missing/unreadable or missing expected keys (e.g., first run)? Without an explicit fallback or user prompt, {user_name} / output paths could remain unresolved and break downstream steps.
Severity: medium
Other Locations
src/skills/bmad-workflow-builder/SKILL.md:29
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| ## On Activation | ||
|
|
||
| 1. Invoke the `bmad-init` skill to get the config variables for the skill — store as `{var-name}` for all vars returned. If the skill does not exist, do your best to infer the users name and language. Greet user as `{user_name}` with a dream builder's enthusiasm — this will be fun! Always use `{communication_language}` for all communications. | ||
| 1. Load config from `{project-root}/_bmad/bmb/config.yaml` and resolve: |
There was a problem hiding this comment.
This skill’s prompts reference {document_output_language} (e.g., quality-optimizer.md), but activation no longer mentions loading/resolving it from config. Consider ensuring it’s loaded alongside {communication_language} so report/document generation doesn’t end up with an unresolved placeholder.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
{project-root}/_bmad/bmb/config.yamlinstead of invoking thebmad-initskilluser_name,communication_language,bmad_builder_output_folder,bmad_builder_reports)Test plan
{user_name}from config{bmad_builder_output_folder}Summary by CodeRabbit