Add coding-agent skillpack generation for local-first onboarding#325
Draft
Add coding-agent skillpack generation for local-first onboarding#325
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new agentguard skillpack CLI workflow to generate repo-local AgentGuard defaults plus coding-agent instruction files, making local-first onboarding more turnkey and updating docs/release artifacts to match.
Changes:
- Introduces
sdk/agentguard/skillpack.pyand wires it into the CLI asagentguard skillpack(print + JSON +--write). - Adds unit tests and updates architecture allowlist for the new module.
- Updates onboarding docs / PyPI README / changelog and includes proof artifacts for the generated outputs.
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/agentguard/skillpack.py | New generator for .agentguard.json + agent-specific instruction files; supports JSON + write-to-disk. |
| sdk/agentguard/cli.py | Adds skillpack subcommand and CLI flags; imports new module. |
| sdk/tests/test_skillpack.py | New tests covering JSON output, target selection, write behavior, overwrite refusal, and CLI wiring. |
| sdk/tests/test_architecture.py | Adds skillpack.py to the architecture module allowlist. |
| README.md | Documents the new agentguard skillpack --write onboarding flow. |
| docs/guides/getting-started.md | Mentions skillpack as a way to materialize repo-local instruction files. |
| docs/guides/coding-agents.md | Adds skillpack usage as the preferred way to generate instruction files. |
| docs/guides/coding-agent-safety-pack.md | Updates safety-pack guide to reference/generated via skillpack and updates verification commands. |
| sdk/PYPI_README.md | Adds skillpack usage to the packaged README. |
| CHANGELOG.md | Notes the new skillpack feature and doc updates under Unreleased. |
| proof/skillpack/write-output.txt | Captures example output for skillpack --write. |
| proof/skillpack/codex-write-output.txt | Captures example output for codex-targeted write. |
| proof/skillpack/claude-output.txt | Captures example output for claude-code target. |
| proof/skillpack/all/.agentguard.json | Example generated repo config for “all” target. |
| proof/skillpack/all/AGENTS.md | Example generated Codex instructions. |
| proof/skillpack/all/CLAUDE.md | Example generated Claude Code instructions. |
| proof/skillpack/all/.github/copilot-instructions.md | Example generated Copilot instructions. |
| proof/skillpack/all/.cursor/rules/agentguard.mdc | Example generated Cursor rule file. |
| proof/skillpack/codex/.agentguard.json | Example generated repo config for codex target. |
| proof/skillpack/codex/AGENTS.md | Example generated Codex instructions for codex target. |
| PR_DRAFT.md | Updates the draft PR narrative to reflect the skillpack work. |
| ops/03-ROADMAP_NOW_NEXT_LATER.md | Marks “Coding-agent skillpack generation” as Done. |
| MORNING_REPORT.md | Updates status/validation notes to reflect the skillpack shipment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Draft
Title
Add coding-agent skillpack generation for local-first AgentGuard onboarding
Summary
agentguard skillpackso developers and coding agents can generate repo-local.agentguard.jsondefaults plus instruction files for Codex, Claude Code, GitHub Copilot, and Cursoragentguard doctor,agentguard quickstart --framework raw --write, local starter run, local reportScope
sdk/agentguard/skillpack.pysdk/agentguard/cli.pysdk/tests/test_skillpack.pyandsdk/tests/test_architecture.pyREADME.md,docs/guides/getting-started.md,docs/guides/coding-agents.md, anddocs/guides/coding-agent-safety-pack.mdsdk/PYPI_README.mdproof/skillpack/Non-goals
Proof
python -m ruff check sdk/agentguard/skillpack.py sdk/agentguard/cli.py sdk/tests/test_skillpack.py sdk/tests/test_architecture.pypython -m pytest sdk/tests/test_skillpack.py sdk/tests/test_quickstart.py sdk/tests/test_architecture.py -vpython scripts/sdk_preflight.pypython -m pytest sdk/tests -v --cov=agentguard --cov-report=term-missing --cov-fail-under=80python scripts/sdk_release_guard.pypython -m bandit -r sdk/agentguard -s B101,B110,B112,B311 -qproof/skillpack/write-output.txtproof/skillpack/claude-output.txtproof/skillpack/codex-write-output.txtproof/skillpack/all/Operator note
PYTHONPATH=<repo>/sdkbecause this machine has another editableagentguard47install that can shadow branch code