Local password authentication. #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion (sans salt and hash fields). This is instead of having a hard-coded .userId field and having only it and .loggedIn be returned.
|
I've barely started with node.js, but this patch seems to make a lot of sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, my first open source commit (attempt!).
I've been using everyauth for a few weeks now and it's been quite useful!
While using the password authentication scheme, I still wanted to be able to pull information about the user. However, none of the information that was automatically retrieved from the other authentication schemes (ex, I tested with Twitter) was accessible.
Upon reading the source I found that the sessions .userId was being hard set to an expected user.id (or apparently in a later push, a configurable primary key).
Here was my solution to the problem anyway- if the user is available, we should push all the fields we have into the session. (In my case, I chose to exclude the 'salt' and 'hash' fields for my users passwords, this should probably be set up to be an configurable exclusions list).