Added node-gyp build system, and version bumped#13
Open
godsflaw wants to merge 1 commit intobnoguchi:masterfrom
godsflaw:master
Open
Added node-gyp build system, and version bumped#13godsflaw wants to merge 1 commit intobnoguchi:masterfrom godsflaw:master
godsflaw wants to merge 1 commit intobnoguchi:masterfrom
godsflaw:master
Conversation
Author
|
I should have also have noted that the current version does not compile correctly on 64 bit Mac as the old build system makes a 32bit Mach-o shared library. The solution was to upgrade to the new build system. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the node-gyp build system for node >= 0.8.0 and version bumped so you can update in npm. Also, I updated the Readme.md with instructions for those on newer versions of node. Feel free to tweak as you see fit.
Tested on Mac, FreeBSD, and Linux. You may want to test on Windows too.
So far, runs good. Thanks for the hard work. :)