NaN-boxed JsValues
#1830
Closed
NaN-boxed JsValues
#1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
Test262 conformance changesVM implementation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
- Coverage 41.33% 41.09% -0.25%
==========================================
Files 234 236 +2
Lines 22019 22121 +102
==========================================
- Hits 9101 9090 -11
- Misses 12918 13031 +113 ☔ View full report in Codecov by Sentry. |
Benchmark for 1c5cdd5Click to view benchmark
|
Benchmark for 48d894dClick to view benchmark
|
Member
|
Does rust-lang/rust#73328 affect the WebAssembly build? |
Member
Author
I don't think it would, but I'll need to test this :) |
HalidOdat
force-pushed
the
nan-boxing
branch
from
0efcd3d to
7f71cef
Compare
Member
Author
It works just fine 🚀 |
Benchmark for 9e3317eClick to view benchmark
|
jedel1043
reviewed
Feb 28, 2022
HalidOdat
force-pushed
the
nan-boxing
branch
from
7f71cef to
5492f43
Compare
Benchmark for 91d24cfClick to view benchmark
|
Member
|
Didn't want to squash the commits but the rebase was pretty painful otherwise. |
HalidOdat
commented
Mar 3, 2022
Member
|
For now I undid returning refs. I'm thinking more carefully about how we can return refs without causing too much havoc, I'll make a PoC soon |
Benchmark for 09d99ddClick to view benchmark
|
Member
Author
The way I thought of doing it was by having a wrapper struct on #[derive(Debug)]
pub struct Ref<'a, T> {
inner: ManuallyDrop<T>,
_marker: PhantomData<&'a T>,
}
impl<T> Ref<'_, T> {
#[inline]
fn new(inner: ManuallyDrop<T>) -> Self {
Self {
inner,
_marker: PhantomData,
}
}
}
impl<T> std::borrow::Borrow<T> for Ref<'_, T> {
fn borrow(&self) -> &T {
&*self.inner
}
}
impl<T> AsRef<T> for Ref<'_, T> {
fn as_ref(&self) -> &T {
&*self.inner
}
}
impl<T> std::ops::Deref for Ref<'_, T> {
type Target = T;
#[inline]
fn deref(&self) -> &Self::Target {
&*self.inner
}
}This struct must not implement |
Member
|
Nice! Should I make a PR with the changes or do you plan on doing it? |
Member
Author
Sure, you can do it if you want! :) |
Benchmark for 27ebfefClick to view benchmark
|
Member
|
Is there anything else missing? |
Member
Author
Not sure, it should work. I'll debug it when I get some time this week :) |
Benchmark for ec8fdefClick to view benchmark
|
Benchmark for 0d9ef33Click to view benchmark
|
HalidOdat
commented
Jun 3, 2022
Member
Author
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Looks good to me! :)
Benchmark for 2d419b1Click to view benchmark
|
Member
|
Moving it for 0.16 to give some time for deeper reviewing, as discussed in Discord. |
Member
|
Moving to 0.17, because I had a slightly safer API using a |
Co-authored-by: HalidOdat <halidodat@gmail.com>
jedel1043
force-pushed
the
nan-boxing
branch
from
04d6993 to
f6bf8f4
Compare
jedel1043
added
run-benchmark
Member
|
Blocked since we want to first abstract |
Member
|
Closing in favour of #4091. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1373
This PR implements
JsValueNaN boxing It is a work in progress, and requires a lot more changes.