Skip to content

Duration code should not use a trivalued Sign internally #638

@Manishearth

Description

@Manishearth

While working on #636, I discovered that the nudge and rounding code all uses Sign, which is Positive/Negative/Zero. However, in the spec, it is only allowed to be Positive or Negative. This leads to confusion around the zero case.

We should use a different enum, maybe InternalSign.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions