Add a new PartialYearMonth to available partial structs (#288) #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…boa-dev/temporal Add PartialYearMonth struct
Fix compilation warnings
nekevss
requested changes
Jun 12, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This is looking good overall. I have one small nit, but then everything should be good to go.
nekevss
added
C-enhancement
nekevss
approved these changes
Jun 21, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Perfect! Thanks for addressing the nitpick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #288