Skip to content

Add convenience methods for constructing FFI datetime types from milliseconds #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jedel1043 merged 1 commit into from
Jun 21, 2025
Merged

Add convenience methods for constructing FFI datetime types from milliseconds #359

jedel1043 merged 1 commit into from
Jun 21, 2025

Conversation

@Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Jun 20, 2025

This goes through multiple intermediate types, which is more expensive over FFI.

@nekevss nekevss added the C-FFI Changes related to FFI label Jun 21, 2025
@jedel1043 jedel1043 merged commit 6a8e5f4 into boa-dev:main Jun 21, 2025
8 checks passed
@Manishearth Manishearth deleted the from-ms-ffi branch June 21, 2025 22:23
@linusg linusg mentioned this pull request Sep 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees

No one assigned

Labels

C-FFI Changes related to FFI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Manishearth @jedel1043 @nekevss