Support RoundNumberToIncrementAsIfPositive #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
instant-rounding
branch
from
0da8085 to
5a93fdf
Compare
Manishearth
force-pushed
the
instant-rounding
branch
from
5a93fdf to
a309120
Compare
nekevss
approved these changes
Jul 23, 2025
| unsigned_rounding_mode: UnsignedRoundingMode, | ||
| ) -> u128 { | ||
| ) -> i128 { | ||
| // (x is dividend / divisor) |
Member
There was a problem hiding this comment.
note: Good comment. If you want to expand, it's primarily because x is assumed to be a float. So x is not passed in because we deal with integers and the remainder would be lost.
nekevss
pushed a commit
that referenced
this pull request
Jul 25, 2025
The spec often deals in ns values without checking for validity; e.g. in Duration.total. Fixes or makes progress on these tests (Some also need #440) ``` 'built-ins/Temporal/Duration/compare/relativeto-string-limits': [FAIL], 'built-ins/Temporal/Duration/prototype/round/relativeto-string-limits': [FAIL], 'built-ins/Temporal/Duration/prototype/round/relativeto-sub-minute-offset': [FAIL], 'built-ins/Temporal/Duration/prototype/subtract/result-out-of-range-3': [FAIL], 'built-ins/Temporal/Duration/prototype/total/relativeto-string-limits': [FAIL], 'built-ins/Temporal/Duration/prototype/total/relativeto-sub-minute-offset': [FAIL], 'built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/default-overflow-behaviour': [FAIL], 'built-ins/Temporal/PlainYearMonth/compare/compare-reference-day': [FAIL], 'built-ins/Temporal/PlainYearMonth/prototype/equals/compare-reference-day': [FAIL], 'built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/default-overflow-behaviour': [FAIL], 'built-ins/Temporal/ZonedDateTime/compare/argument-string-limits': [FAIL], 'built-ins/Temporal/ZonedDateTime/from/argument-string-limits': [FAIL], 'built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-limits': [FAIL], 'built-ins/Temporal/ZonedDateTime/prototype/since/argument-string-limits': [FAIL], 'built-ins/Temporal/ZonedDateTime/prototype/until/argument-string-limits': [FAIL], ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
This basically required rewriting the round code to stop assuming that everything is positive. I'm not 100% sure of the correctness, but the tests help.
Can be reviewed commit-by-commit.