Add .clone() to FFI, YearMonth::reference_day #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
approved these changes
Jul 26, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
LGTM
question: would this be cheaper if the types are Copy?
Contributor
Author
|
@nekevss Doesn't matter, they're allocated over FFI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this ToTemporalYearMonth isn't possible to implement since you cannot extract the reference day.
Decided to add clone everywhere since it's a useful enough operation and ToTemporalFoo always needs it (even though it can usually be implemented differently)