Correctly normalize timezones #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
tz-normalize-kolkata
branch
from
913b99d to
47676bd
Compare
Manishearth
force-pushed
the
tz-normalize-kolkata
branch
from
47676bd to
699ba7c
Compare
nekevss
approved these changes
Jul 28, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
One spelling nit. But besides that, it looks great to me!
Co-authored-by: Kevin Ness <46825870+nekevss@users.noreply.github.com>
Manishearth
force-pushed
the
tz-normalize-kolkata
branch
from
3e39fdc to
1745275
Compare
Manishearth
force-pushed
the
tz-normalize-kolkata
branch
from
1745275 to
b59461f
Compare
Contributor
Author
|
Ah, this has a problem: the tzdb data treats |
Merged
Manishearth
added a commit
that referenced
this pull request
Jul 29, 2025
It seems like there are tests that depend on UTC being normalized to UTC and not Etc/UTC. Broken by #460. Another fix would be to change this in `normalize_identifier_with_compiled`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ironically worked on this whilst on a flight to Kolkata)