Fix overflow when validating Duration #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
added
C-bug
Manishearth
approved these changes
Jul 31, 2025
Contributor
|
Huh, I'm surprised I haven't hit this yet But I only run test262 in release mode locally, and I suspect CI hasn't failed yet since there are a pile of other Duration validity bugs that have yet to be synced into a CI'd version of V8 |
Member
Author
|
I was running this on Boa locally. Part of the issue is probably technically with how Boa constrains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boa currently panics when running the test suite in debug. This fix addresses that issue.
Relevant test: test/built-ins/Temporal/Duration/large-number.js
Boa's conformance results:
https://boajs.dev/conformance?version=main&testPath=built-ins%2FTemporal%2FDuration&selectedTest=large-number.js