cleanup: Remove parsing functionality from PartialZDT #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Manishearth
force-pushed
the
partialzdt-cleanup
branch
from
a26d877 to
ef3deae
Compare
nekevss
approved these changes
Aug 6, 2025
Manishearth
added a commit
that referenced
this pull request
Aug 6, 2025
Let's wait for #493 before merging this, but might as well get a release out now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was introduced in #420, but we now have separate parsed variants for everything (#486). These are no longer necessary; and the additional bits of data for dealing with matchMinutes, START-OF-DAY, and hasUTCDesignator are similarly extraneous.