Move TimeZone over to being Copy with TimeZoneId #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
timezone-id
branch
5 times, most recently
from
fbf6ee4 to
df755d2
Compare
nekevss
approved these changes
Sep 4, 2025
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum TimeZone { | ||
| IanaIdentifier(String), | ||
| IanaIdentifier(TimeZoneId), |
Manishearth
force-pushed
the
timezone-id
branch
from
df755d2 to
b4c941b
Compare
Manishearth
added a commit
that referenced
this pull request
Sep 10, 2025
We broke this in #538 A default impl for TimeZone is a footgun; the spec default is UTC but we cannot currently compute it without a provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409,#330