Skip to content

Updates to PlainTime API based on review #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Manishearth merged 3 commits into from
Sep 13, 2025
Merged

Updates to PlainTime API based on review #565

Manishearth merged 3 commits into from
Sep 13, 2025

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Sep 13, 2025

This PR reviews the API for PlainTime.

In general a variety of changes were made.

  • rename module from time.rs to plain_time.rs
  • Update the round method to use RoundingOptions over individual options.
  • Adds a new variant to ErrorMessage enum

It's worth noting the update was also made to temporal_capi.

@nekevss nekevss requested a review from Manishearth September 13, 2025 15:43
@Manishearth Manishearth merged commit ab98813 into main Sep 13, 2025
8 checks passed
@Manishearth Manishearth deleted the review-plain-time branch September 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nekevss @Manishearth