Make TimeZone no longer allocate over FFI #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a draft because I want to test it in V8 first, but it's reviewable |
Manishearth
force-pushed
the
tz-ffi-copy
branch
from
06dcf83 to
8378f5d
Compare
Contributor
Author
|
v8 side: https://chromium-review.googlesource.com/c/v8/v8/+/6946460 cc @linusg this may be annoying to migrate over, but should buy a teensy bit of performance |
Manishearth
force-pushed
the
tz-ffi-copy
branch
from
8378f5d to
d8fa9ff
Compare
Contributor
Author
|
Also there is a slight chance Diplomat's choice of type to represent usize isn't perfect. It ought to be fine, but so far Temporal hasn't had usizes over FFI and now it will. |
Contributor
|
Fine by me 👍 |
nekevss
approved these changes
Sep 14, 2025
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Sep 15, 2025
Split this out into a second PR for easier reviewability. boa-dev/temporal#572 makes TimeZone no longer need an allocation, which is a bit more invasive change than most. This was done in preparation for temporal_rs 0.1.0, and we expect far fewer C++ API breaking changes after that version. Bug: 401065166 Change-Id: I6a6a6964dfdea50a54902530276bb52060cebf84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6946460 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#102467}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves a lot of internal stuff to taking TimeZone instead of &TimeZone. I think that's fine but I can revert if requested.