Remove support for unqualified islamic calendar
#609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this was removed from the spec)
nekevss
approved these changes
Oct 29, 2025
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 29, 2025
This updates to temporal_capi 0.1.1, which pulls in the last piece of temporal_rs. With this, we pass almost all test262 tests: the remaining failures are: - Duration precision/rounding edge cases that may need more spec clarification. - Tests for out-of-normal-range Chinese/Korean behavior. These tests are just incorrect. - Test for the `islamic` code. This is being fixed in boa-dev/temporal#609 and will be patched shortly. We might want to let this bake with the fuzzer for a bit first. Bug: 401065166 Change-Id: I7a5ca632078f002fb7c1982b9f7b8a806a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7094981 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#103403}
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Oct 29, 2025
This uplifts boa-dev/temporal#609 The Temporal spec changed to disallow this calendar code, preferring specific calendar codes only. Uplifting this patch so we pass all the tests we care about before release. Change-Id: If4e6ae983828bf5d072e2156a000f924135d08ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097502 Auto-Submit: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1537629}
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
This uplifts boa-dev/temporal#609 The Temporal spec changed to disallow this calendar code, preferring specific calendar codes only. Uplifting this patch so we pass all the tests we care about before release. Change-Id: If4e6ae983828bf5d072e2156a000f924135d08ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097502 Auto-Submit: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1537629}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
This uplifts boa-dev/temporal#609 The Temporal spec changed to disallow this calendar code, preferring specific calendar codes only. Uplifting this patch so we pass all the tests we care about before release. Change-Id: If4e6ae983828bf5d072e2156a000f924135d08ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097502 Auto-Submit: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1537629} NOKEYCHECK=True GitOrigin-RevId: b399127e1683c70a755882cca04aba112ee90b5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this was removed from the spec)