-
Notifications
You must be signed in to change notification settings - Fork 30
Implement logic for a zerocopy compiled time zone provider #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm marking this as ready for review, but I'm very, very close to splitting this apart into separate PRs as this became a much larger change than initially planned. However, all the changes are linked to the primary change. I believe the individual commits are properly separated enough that this could be reviewed, but again I'm not against pulling this apart and splitting it into smaller PRs. There are primarily four changes layered here.
The reason this PR became so large was that the initial goal was to implement 4. However, implementing 4 exposed some bugs in zoneinfo's baked data provider, which prompted 1 (to fix the bugs), 2 (to help identify and diagnose the bugs), and 3 (to fix the bad compiled data with the fixed version). |
|
I probably won't have time to review a change this big, even commit-by-commit, any time soon. So splitting might be better? |
|
Sounds good to me. I'll rework it into smaller PRs. |
This PR implements the logic for the zero copy zone info provider.
Overall, the primary steps taken in this PR is to adapt the logic for the zero copy zoneinfo provider from the tzif module.
Posting this early as a draft for early review / tracking
TODOs: