Skip to content

Allow for SSL connection options to be passed to AnyEvent::Handle#22

Merged
davel merged 1 commit intobobtfish:masterfrom
atoomic:ssl
May 16, 2020
Merged

Allow for SSL connection options to be passed to AnyEvent::Handle#22
davel merged 1 commit intobobtfish:masterfrom
atoomic:ssl

Conversation

@atoomic
Copy link
Copy Markdown

@atoomic atoomic commented Mar 14, 2018

Add an extra option to pass directly a has of AnyEvent::TLS options

(cherry picked from commit 3e6e4a33cd0029e2abc9135cf537c5c9f1cbb4e6)
Signed-off-by: Nicolas R <atoomic@cpan.org>
@cPanelScott
Copy link
Copy Markdown

This PR works and allows connections to SSL-speaking RabbitMQ servers. It doesn't allow for peer verification, but I can propose that in a separate PR.

This PR is old, but it is certainly valuable to anyone who uses RabbitMQ with SSL.

@bobtfish Would you be willing to merge the PR as is, and accept a separate PR to improve peer validation?

@davel
Copy link
Copy Markdown
Collaborator

davel commented May 15, 2020

Hi @cPanelScott,

Have you been in touch with @bobtfish about this change outside of this PR? I'm not currently using AnyEvent::RabbitMQ, but could release the change. It looks fairly safe to me.

@cPanelScott
Copy link
Copy Markdown

I haven't been in touch with @bobtfish. I have one other change to propose. Would you be willing to merge this, and then consider a second PR before releasing?

@davel davel merged commit 9fa03db into bobtfish:master May 16, 2020
@davel
Copy link
Copy Markdown
Collaborator

davel commented May 16, 2020

Hello @cPanelScott. I have merged your change and made a dev release. https://metacpan.org/release/DLAMBLEY/AnyEvent-RabbitMQ-1.19_01

Can you confirm that it works? Adding host verification to TLS sounds very sensible to me, please go ahead.

All the best,
Dave

@cPanelScott
Copy link
Copy Markdown

Yes, this change works. It might take me a few weeks to get the next PR in. It's a one-line addition, but I need to work something else out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants