Skip to content

RT#106550 Add no_ack param to get() #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davel merged 3 commits into from
May 23, 2020
Merged

RT#106550 Add no_ack param to get() #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5749359
RT#106550 Add no_ack param to get()
davel May 22, 2020
544a22d
Merge branch 'master' of github.com:bobtfish/AnyEvent-RabbitMQ into d…
davel May 23, 2020
53f9128
Add contributor
davel May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Revision history for Perl extension AnyEvent::RabbitMQ

- Add "no_ack" flag to "get" method. (Julio Polo)
- Prevent channelMax from overflowing.
https://rt.cpan.org/Ticket/Display.html?id=97716 (Carl Hörberg)
- Merge in documentation patch from
Expand Down
1 change: 1 addition & 0 deletions dist.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ x_contributors = Ruslan Zakirov <ruz@bestpractical.com>
x_contributors = Masahito Ikuta <cooldaemon@gmail.com>
x_contributors = Rod Taylor <rod.taylor@gmail.com>
x_contributors = Carl Hörberg <carl@cloudamqp.com>
x_contributors = Julio Polo <julio@hawaii.edu>

[InstallGuide]
[CPANFile]
Expand Down
8 changes: 7 additions & 1 deletion lib/AnyEvent/RabbitMQ/Channel.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,12 +617,14 @@ sub get {
my $self = shift;
my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_);

my $no_ack = delete $args{no_ack} // 1;

return $self if !$self->_check_open($failure_cb);

$self->{connection}->_push_write_and_read(
'Basic::Get',
{
no_ack => 1,
no_ack => $no_ack,
%args, # queue
ticket => 0,
},
Expand Down Expand Up @@ -1385,6 +1387,10 @@ a notification that there was nothing to collect from the queue.

This callback will be called if an error is signalled on this channel.

=item no_ack

0 or 1, default 1

=back

=head2 ack
Expand Down