Open
Conversation
Most importantly, Clone. See bodil/im-rs#134. Piggy-backing Debug when possible, because, why not. Not implementing Copy even where it would be possible, as that could turn into footgun (iterators "forking"). Not implementing Clone on consuming iterators, as that also clones the elements and that's probably not intended.
Contributor
Author
|
🤔 What's up with the coverage? I admit I don't test the derived trait (should I?), but it seems the change of coverage is empty and the change of percents is just effect of making the files longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, Clone. See bodil/im-rs#134.
Piggy-backing Debug when at it, because, why not.
Not implementing Copy even where it would be possible, as that could
turn into footgun (iterators "forking").
Not implementing Clone on consuming iterators, as that also clones the
elements and that's probably not intended.
Note: I'm submitting it now, but it depends on bodil/bitmaps#4 (currently pulls a git based dependency, which needs to be removed before merging).