Merged
Conversation
Owner
|
I would definitely prefer a different approach - I really don't like the idea of adding another node type here - but I can't think of a better way to do it, and I think it's probably worth the very slight extra overhead to have this feature in the string renderer. So let's merge. |
Contributor
Author
|
@bodil thanks! I'm not super in love with this approach either, but I couldn't think of anything better either 😆 . If you come up with something else I'd be happy to jump in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your work on
typed-html, it's great.I ran into the same issue as #34.
I basically copied the code around
Textand removed the bit that does escaping when rendering to a string. If there's a simpler way or a different approach you would prefer here, let me know.Thanks!