Conversation
|
Thanks for looking into this @jonadaly ! It looks like one the python 3.9 run on windows is failing, possibly due to an incompatible numpy version, do you have any ideas on how to fix that? Once fixed we can land this! |
|
I'm not sure why that's happening - what's weird is that fixing it seems to have broken the 3.12 build! 😆 |
We could drop support for 3.9 too, that's less than a year from EOL, if we do that and revert back to when 3.12 was working we can land this. |
|
And sorry for the delay in responding! Thanks for putting effort into this. |
|
So I've got the CI passing by removing the "legacy build" for >3.11. Not sure how legit that is though - what do you think @bodono ? |
.github/workflows/build.yml
Outdated
| run: | | ||
| echo "PYTHON_SUBVERSION=$(echo $PYTHON_VERSION | cut -c 3-)" >> $GITHUB_ENV | ||
| echo "SINGLE_ACTION_CONFIG=$( [[ $PYTHON_VERSION == 3.8 && $RUNNER_OS == 'macOS' ]] && echo 'True' || echo 'False' )" >> $GITHUB_ENV | ||
| echo "SINGLE_ACTION_CONFIG=False" >> $GITHUB_ENV |
There was a problem hiding this comment.
If this is just always False then we can just remove it, and from line 175 below.
|
Thanks @jonadaly, LGTM after minor update I suggested. Let me know when you think it is ready to merge and I can do it. |
|
Thanks! |
3.8 is EOL for the past 8 months now.. and not built on CI anyway xref: bodono#117
* MAINT: Bump to 3.9 3.8 is EOL for the past 8 months now.. and not built on CI anyway xref: #117 * ENH: Rework meson build Be more DRY * ENH: Add use_openmp for meson * ENH: Setup installation directory Stop polluting site-packages with _scs*.so * MAINT: Move to enable python -mpytest test in the same directory, otherwise scs/__init__.py shadows the one installed with python -mpip install . * CI: Use meson for openmp * MAINT: Add in rt similar to legacy_setup * ENH: Add in more options from legacy_setup * ENH: Try to setup the GPU variant * CI: Fix typo * MAINT: Try to explicitly take mkl * MAINT: More typos * MAINT: Try mkl again * CI: Rework * MAINT: Use configuration over CI
2 participants
Hi @bodono , I tried to mirror your changes from my previous request to support Python 3.12 / MacOS - now for the new release of Python 3.13!
I've also removed support for Python 3.8 since it's now end-of-life.