Fix bug when field gets converted to blacklisted word#36
Merged
bogdandm merged 1 commit intobogdandm:masterfrom Jun 8, 2021
Merged
Fix bug when field gets converted to blacklisted word#36bogdandm merged 1 commit intobogdandm:masterfrom
bogdandm merged 1 commit intobogdandm:masterfrom
Conversation
Owner
|
Thank you, this is pretty good fix. I think there is one more minor case when after all conversions class name could shadow other global definitions in camel case (like True/False/Exception). But it could be fixed sometime in the future, it's quite rare to see field named liked this. I will look closely to this later. |
Owner
|
Currently I could not publish new minor version because of broken/outdated Travic-CI pipeline 😞 I will migrate this project to https://www.travis-ci.com/ (or maybe github-actions) in few weeks and than I will make a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that if a field name contains upper-case letters, then the underscore won't be appended to the resulting field name if it is reserved (blacklisted, in terms of the project). For example, one might expect
IDto be converted toid_but it appears asidin the model.The solution is to change the order of string operations: