Make node-sass pass in citgm #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this working? I would be interested in trying it out. |
Author
|
It works in my citgm run. Feel free to try it out. You might not need to change the supported version part if you are not compiling node from source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently node-sass does not support node version higher than 8, so I add the case for node 9 to make it able to run with node master
at the end of running
npm install, the prepublish script gets invoked as well, and thenot-in-installandin-installcondition isn't stopping it. so I change the condition toin-publishandnot-in-publish. Since npm complainprepublishis deprecated, so I also change it toprepare.