Carriers and service levels for shipping methods#6
Closed
Senjai wants to merge 16 commits intobonobos:masterfrom
Closed
Carriers and service levels for shipping methods#6Senjai wants to merge 16 commits intobonobos:masterfrom
Senjai wants to merge 16 commits intobonobos:masterfrom
Conversation
There's no behavior change to this. It allows subclasses to easily override how to determine the user.
When a stock transfer already has a tracking number, the value was being overridden by the default value of the ship method.
… viewable stock locations. When given the stock transfer display or stock transfer management permissions, there is a dropdown in admin/stock locations to filter by stock locations, which was filled by the ability to transfer_to or transfer_from a stock location. This change allows people with the stock transfer permission sets to use that feature of stock transfers without having to also have the ability to transfer_to or transfer_from a stock location.
* Ability to cancel a unit after it has been marked shipped * Easy way to reimburse units after Order has been completed
This is causing errors in our builds: Asset was not declared to be precompiled in production. and NoMethodError: undefined method `register_engine' for nil:NilClass
Same thing as 5988804. This was making api, sample, and core specs fail.
The main impetus of this is Tulip in which the guides have a much more non-linear approach to creating an order, but the same problem exists through the web client too. Other approaches have been tried, but lets try this within the Estimator itself. An extra side-effect of this is that we don't delete shipments in Order#ensure_updated_shipments so that's poorly named now, but it also raises a question of why it's called when it is. This means a shipment will stick with an order if created before we reach the "delivery" state of the order. Upon transition into "delivery" then #created_proposed_shipments gets called to ensure they're correct. The new logic in the Estimator now will re-select any prior shipping method/rate selection the customer had previously made.
preserve shipping method when shipments change
Senjai
changed the title
When we're dealing with a shipping method, we have no formal way of adding additional information that would be useful for fulfillment purposes. We can add an "internal" name to the shipping method, but that would require pattern matching to get any useful information from. Often, in most fulfillment scenarios, we have a desire to know _exactly_ what carrier and service level a specific shipping method is representative of. Given a shipment I can then infer that it should be shipped with UPS one day shipping by introspecting on the methods' carrier and service_level columns as necessary. This is optional as it stands, but validations can be added in stores as required for complex fulfillment scenarios.
Allows users to set service levels and carriers for shipping methods on the backend.
Senjai
force-pushed
the
bonobos_carriers
branch
from
520825b to
43b90bd
Compare
Author
|
Wrong target branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to solidusio#730