Capture operation state before transport creation #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport initialization and disposal are asynchronous and also depend on operator state, which may be shared across parallel subscriptions. To allow dynamic instantiation of transports from a single operator, this state needs to be captured immediately on observable creation and retained as a copy throughout the entire transport lifetime. It is not enough to capture on subscribe, since error handling operators such as Retry may inadvertently cause state to be shared, and also the async lambda is not guaranteed to run synchronously even if the first few steps are calls to synchronous methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport initialization and disposal are asynchronous and also depend on operator state, which may be shared across parallel subscriptions. To allow dynamic instantiation of transports from a single operator, this state needs to be captured immediately on observable creation and retained as a copy throughout the entire transport lifetime.
As a further note, it is not enough to capture on subscribe, since error handling operators such as
Retrymay inadvertently cause state to be shared, and also the async lambda is not guaranteed to run synchronously even if the first few steps are calls to synchronous methods.Fixes #96