-
Notifications
You must be signed in to change notification settings - Fork 5
Common CI/CD and repository layout #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eec68c4 to
1b6c494
Compare
|
Fixing this workflow properly will not be feasible before 2.9, so for now this PR will have rendering images and deploying docs disabled. I created #57 to make sure we remember to follow up on this. |
|
Given that the full CI/CD workflow can't build the ml docs just yet, can we temporarily keep the original docs build workflow for this PR so that we still have the option to manually update the site as needed? |
That's the plan if the problem is more complicated than I'm hoping. I meant to look at this again earlier this week but got sidetracked. I'm pretty sure it's going to be something simple, I just need dig into it locally since debugging via CI when it takes like 10 minutes to get to the point where it fails is untenable. |
|
I found the underlying issue and as predicted it was dumb. Will submit a fix and details tomorrow morning. |
9945576 to
3ccde47
Compare
|
So much for "tomorrow morning", sorry about that 😅 The PR is fixed. The main fix was updating to Bonsai 2.9.0, but I also had to fix bonsai-rx/machinelearning-examples#18 should be merged before this one. Please take special note of 3ccde47 -- These workflows were out-of-date and broken due to various refactorings over the course of the past 6 months. (Thankfully CI will help these get noticed and fixed sooner going forward.) The underlying issue that broke this repo had nothing to do with common CI, but was caused spirits. The ghost of Windows 95 has come back to haunt us. Specifically this is happening because because the name All of these together mean that installing Thankfully Gonçalo randomly thought to enable long path support for Bonsai 2.9.0 via bonsai-rx/bonsai#2016 So for the most part, the underlying fix was to upgrade all of the environments to Bonsai 2.9.0 The app manifest change also had to be applied to setup-bonsai to give it long path support too, and I had to fix an unrelated compatibility issue with 2.9.0 in setup-bonsai that showed up. Because Bonsai 2.9.0 doesn't tolerate broken workflows when rendering workflow images (bonsai-rx/bonsai#2267) I had to fix some workflows which had been silently broken for a while now. |
Bonsai.Scripting.Expressions` does not support .NET Standard and is a direct dependency
Cherry picked from bonsai-rx#47

bonsai-rx/machinelearning-examples#18 should be merged prior to merging this PR.
(This PR was created semi-automatically.)
This PR brings the first iteration of the new standardized repository layout and CI workflows.
Major highlights include:
CONTINUOUS_DOCUMENTATIONvariable toggles it.)Please note that there's still much I plan to do. More important than anything is that everything is consistent now which will make it easier to improve things going forward. Please resist the urge to tweak things that aren't outright broken. It's important that these PRs are merged sooner rather than later for anything being actively developed.
If this PR is marked as a draft, it's because the pipeline is known to be broken for some reason. See my org profile readme for links a status overview and links to various assets, along with a list of known-broken and excluded projects along with reasoning.