New feature additions to core Bonsai.ML.Torch package
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tensors by decomposing along a dimension
…native libtorch method
…odes (enabled grad, inference, no grad)
…rn empty string rather than empty tensor
…n is only happening on subscription and not before that
…` to avoid confusion with what is considered "native" in this case (is .NET native or torch native?)
…ors true function (splitting along dimension)
ncguilbeault
force-pushed
the
dev/torch-core-additions
branch
from
c7c4771 to
26900fd
Compare
glopesdev
reviewed
Nov 12, 2025
Co-authored-by: glopesdev <g.lopes@neurogears.org>
…lied it to `CreateTensor` and `Diagonal` operators
…d values of range
glopesdev
approved these changes
Dec 12, 2025
Member
glopesdev
left a comment
glopesdev
left a comment
There was a problem hiding this comment.
@ncguilbeault Looks good to me, I just made comments on a few missing XML docs in case you want to fill them in, otherwise I am happy to merge this.
Member
|
@ncguilbeault All looks good to me, I would just look into the few remaining unresolved conversations above, especially the ones around |
… TorchSharp's .NET specific serialization method
…iables are set explicitly
glopesdev
reviewed
Dec 19, 2025
Member
glopesdev
left a comment
glopesdev
left a comment
There was a problem hiding this comment.
All looks great now, just a few missing bits of documentation, but we could also leave them for the next PR, if easier.
glopesdev
reviewed
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a few new operators and enhancements to the
Bonsai.ML.Torchpackage. Major additions include new operators for buffering, deconstructing, and printing tensors, as well as operators for controlling gradient and inference modes. There are also improvements to file format support and device initialization, plus a new base class for automatic tensor type conversion.