Potential Vulnerability in Cloned Code#3086
Draft
pr-hung wants to merge 1 commit intoboostorg:developfrom
Draft
Conversation
…parser/http_parser.c)
Contributor
|
This code, as the names suggest, is part of a comparative benchmark only. As such, the code was cloned at the specific time the comparison was done, and represents an "archive copy" for reproducing the results. Of course, we might remove the archive copy and replace it with a revision link to the source repository, or at least clearly mark the files as old and having security issues. But in short, unless users willingly do not use Boost Beast, but instead use some benchmark code that is not part of Boost Beast, there is no security issue here. Interestingly, Beast might have corresponding issues with multiple Transfer-Encodings, but that's not the topic of this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential security vulnerability in cloned code that appears to have missed an upstream security patch.
Details
test/bench/parser/nodejs-parser/http_parser.cWhat this PR does
References
Please review and merge this PR to ensure your repository is protected against this potential vulnerability.
Thank you for your time !