Remove dependencies on Boost.StaticAssert #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The change to include_library.yml is wrong. |
Member
Author
|
Why? The intent is to remove usage of the Boost.StaticAssert submodule, and the change removes its usage from CMake testing. Am I missing something? |
Member
|
I prefer to keep it in the list for now. If/when we remove it, I'll remove it. |
Boost.StaticAssert has been merged into Boost.Config and its submodule should not be used anymore, so remove the dependency and tesing the library in CI. Boost.StaticAssert is still retained in include_library.yml GHA config to continue testing the submodule until it is removed, at request by Peter Dimov.
Lastique
force-pushed
the
feature/remove_static_assert
branch
from
3ae201b to
1686f57
Compare
Member
Author
|
Ok, as you wish, I removed the change to include_library.yml. |
Member
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost.StaticAssert has been merged into Boost.Config and its submodule should not be used anymore, so remove the dependency and tesing the library in CI.