Redundant condition

[PHackett]

format/include/boost/format/alt_sstream_impl.hpp

Line 127 in 78ef371

else if(way == ::std::ios_base::beg)

Line 127 is -
else if(way == ::std::ios_base::beg)

It is followed on line 129 -
else if(way != ::std::ios_base::beg)

Which, of course is always true given the previous test. This "impossible-redundant-condition" was spotted by a source analyser I used.

[jeking3]

I think the proper solution here is likely the following on lines 129, 130:

                else if(way != ::std::ios_base::cur || (which & ::std::ios_base::in) )
                    // (altering in&out is only supported if way is beg or end, not cur)

Similar to the logic on lines 110, 111:

                else if(way != ::std::ios_base::cur || (which & ::std::ios_base::out) )
                    // (altering in&out is only supported if way is beg or end, not cur)

[jeking3]

@PHackett any thoughts on this approach?

[PHackett]

This was spotted by a static code analyser in an old version of boost - it was fixed in a later version.
I suggest that you look at newer versions of the library to see what fix was applied.

[jeking3]

It actually wasn't fixed, but what I suggested was too complicated. Thanks.