-
Notifications
You must be signed in to change notification settings - Fork 169
Fix compile error on clang and documentation #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mloskot Do you know the way to handle "late" commit to |
I don't know any general Boost policy, but I know some maintainers decided to cherry-pick commits. I recall this old discussion on the merge policy in #663 where we seem to decided we prefer true merges, but we also don't object cherry-picking. |
|
Thanks! I did cherry-pick first before creating this PR, hoping to bypass this issue: But no luck. How can I temporarily disable the protection on |
Please, try again. You should be able to see it now :) |
|
I am adding the doc fixup as well since we don't need permission for that. The CI is stuck, but I suppose this PR lacks the necessary fixes. I am planning to fix the CI and merge develop for the next release. |
mloskot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Description
Fixes #775
Ports #767 from develop to master ~mloskot
References
Permission granted to merge this fixup on master for 1.90:
https://lists.boost.org/archives/list/boost@lists.boost.org/message/RVU7AKXUXA6X6K3MG4ZEQZ5WIWVW7I5E/