Fix for Ticket #7729 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SVN r75124]
[SVN r75140]
[SVN r75165]
[SVN r75431]
[SVN r75547]
[SVN r75861]
…ypos in other doc pages [SVN r75862]
[SVN r75863]
[SVN r75878]
…scriptor class [SVN r75891]
[SVN r75906]
[SVN r75970]
[SVN r75973]
[SVN r75974]
…_graph; changed name of member to prevent future use [SVN r76049]
[SVN r76083]
[SVN r76394]
[SVN r76439]
[SVN r76588]
[SVN r76648]
[SVN r76651]
[SVN r76654]
[SVN r76726]
[SVN r76779]
[SVN r76867]
[SVN r76868]
[SVN r85934]
[SVN r86028]
[SVN r86059]
[SVN r86136]
…n-partial-specialization compilers; enabled C++11 unordered containers when they are present; refs #8962 [SVN r86137]
…9229 [SVN r86236]
Process #ifdef...#endif blocks. [SVN r86243]
Process #ifndef...#endif conditions. [SVN r86244]
Process #ifndef...#else...#endif blocks. [SVN r86245]
… on callback usage to match current documentation); removed special-casing of empty graphs; added patch from #9246 for correct return values; did not make change to documentation suggested there since I chose to have the callback called even for empty graphs; fixes #9246 [SVN r86336]
…ap directories and namespaces; this fixes circular dependencies between these two libraries (assuming boost/property_map/parallel is treated as a separate library) [SVN r86381]
…in documentation; fixes #9300 [SVN r86456]
[SVN r86502]
[SVN r86577]
[SVN r86604]
…enable move semantics [SVN r86733]
Contributor
Author
|
I should've submitted this against the develop branch, sorry. |
concept_def.hpp and concept_undef.hpp need to be matched when used.
Contributor
Author
|
Closing in favor of the request against develop. |
felix-salfelder
referenced
this pull request
in felix-salfelder/graph
Feb 28, 2017
removing an element from a stack does not always work, since the predecessor of a stack element is not (always) stored. this patch merges the array head into next, so a top element in a stack can point to the head of the stack it is in. remarks: - i am guessing the intended use (see test below), as it works like that for elements deeper down in a stack - the fix abuses pointers/iterators and infers offsets from address differences. (yes it's a bit ugly.) - memory needs and complexity are unaffected, size_type is probably big enough. test case. B is a bucketsorter operating on a vector V. V[0]=0; V[1]=1; B.push(0); B.push(1); // now, stacks 0 and 1 are singletons. // try to move 0 to stack #1, should result in // head_1->0->1->end, but calls remove first, then V[0]=1; B.update(0); // <- BOOM // the update calls remove, it "removes" 0 from stack #V[0]=1. // it's not there yet (!). // instead 1 (top of bucket #1) must die. // the result is head_1->0->end, and wrong.
felix-salfelder
referenced
this pull request
in felix-salfelder/graph
Aug 31, 2018
removing an element from a stack does not always work, since the predecessor of a stack element is not (always) stored. this patch merges the array head into next, so a top element in a stack can point to the head of the stack it is in. remarks: - i am guessing the intended use (see test below), as it works like that for elements deeper down in a stack - the fix abuses pointers/iterators and infers offsets from address differences. (yes it's a bit ugly.) - memory needs and complexity are unaffected, size_type is probably big enough. test case. B is a bucketsorter operating on a vector V. V[0]=0; V[1]=1; B.push(0); B.push(1); // now, stacks 0 and 1 are singletons. // try to move 0 to stack #1, should result in // head_1->0->1->end, but calls remove first, then V[0]=1; B.update(0); // <- BOOM // the update calls remove, it "removes" 0 from stack #V[0]=1. // it's not there yet (!). // instead 1 (top of bucket #1) must die. // the result is head_1->0->end, and wrong.
jzmaddock
pushed a commit
that referenced
this pull request
Oct 12, 2018
Creating first batch merge to bring in well formed bugfixing pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concept_def.hpp and concept_undef.hpp need to be matched when used.