Explicitly use vertex type on quick tour example. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm okay with making this change, in the develop branch, not master. While I don't think the change is actually necessary, I could see where it might help a novice get up the learning curve more quickly. Please rebaseline this pull request against develop, or close this and make a new request. |
jzmaddock
pushed a commit
that referenced
this pull request
Oct 12, 2018
Creating first batch of merges for well formed bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to explicitly use types on the tutorial so that new users know what types are returned.
I am learning the interface now and this is the first question that came to my mind when reading this, and I had to search a bit for the answer.
BTW, this Git repo is the official place to contribute to Boost Graph is that it?