Skip to content

Conversation

@j-4
Copy link
Contributor

@j-4 j-4 commented Oct 7, 2015

…vely add to parent subgraphs

Hello,
One of the invariants of an induced subgraph is:

  • If vertex u is in subgraph g, then u must be in g.parent().

This is true if you call add_vertex(g) on a subgraph to create a new vertex.
If you however choose to add a already existing global vertex to the subgraph, this addition is not propagated to the parents of this subgraph.

I assume this is a bug and fixed it.
Bug Ticket can be found here: https://svn.boost.org/trac/boost/ticket/11714
Thanks, Stefan

@murraycu
Copy link
Contributor

If I were the maintainer (I'm not), I would prefer these commits to be squashed for easier reviewing.

@murraycu
Copy link
Contributor

https://svn.boost.org/trac/boost/ticket/11714 has a unit test for this. Shouldn't that be part of this pull request too?

@Belcourt
Copy link
Member

Belcourt commented Nov 1, 2016

Any chance you could squash these and add the referenced unit test case?

@j-4
Copy link
Contributor Author

j-4 commented Nov 2, 2016

Hi,
I added the unit test into the testing framework and squashed the commits.
However, I have no idea to change the commit history here, so I generated a new pull request:
#80

Thanks for merging the bugfix :)
Let me know, if you need anything else!

@j-4 j-4 closed this Nov 2, 2016
@j-4 j-4 deleted the fix-add_vertex-subgraph branch November 2, 2016 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants