Replace /bin/bash with /bin/sh #95
Conversation
/bin/bash is a Linuxism. /bin/sh is portable, and this script isn't using any bash-specific features.
|
I'm helping out with the PR backlog. BSD, Linux, Mac, and now Windows have bash support. Why is this change needed? This will be in the first batch of merged PR's. This is to let you know and help me prioritize PR's. |
|
Because while bash can run almost everywhere, it isn't necessarily installed by default, and on many systems /bin/bash isn't the correct path. /bin/sh is correct on every unix system. |
|
Could you provide an example? I'd like a concrete need in order to immediately accept this. |
|
On the BSDs, bash is usually installed to /usr/local/bin/bash, and is not installed by default. On OSX, it can vary based on whether you're using homebrew, macports, etc. I've even heard of Linux distros that don't use /bin/bash, but I can't find any on Google right now. Some programs use "#! /usr/bin/env bash", which is more portable. But it's always better to use "#! /bin/sh" for scripts that are bourne-compatible, which this one is. |
|
Good enough for me. I'll add this to the first batch of merges since it can fix things. |
3 participants
/bin/bash is a Linuxism. /bin/sh is portable, and this script isn't
using any bash-specific features.