Workaround -Wunused-parameter #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| template < typename Heap1, typename Heap2 > | ||
| bool value_equality( Heap1 const& lhs, Heap2 const& rhs, typename Heap1::value_type lval, typename Heap2::value_type rval ) | ||
| { | ||
| [[maybe_unused]] rhs; |
Collaborator
There was a problem hiding this comment.
maybe_unused is c++17, this library is still c++14. boost::ignore_unused would be more compatible.
also, please use spaces instead of tabs (or ideally use pre-commit to format the code
georgthegreat
force-pushed
the
fix-unused
branch
from
6ea7b89 to
fc0bf00
Compare
Contributor
Author
|
The syntax turned out to be incorrect, so I changed it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.