Skip to content

Add noexcept to destructors to support /Zc:implicitNoexcept-. Fixes #557. #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grisumbras merged 1 commit into from
Oct 8, 2021
Merged

Add noexcept to destructors to support /Zc:implicitNoexcept-. Fixes #557. #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/json/array.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class array
No-throw guarantee.
*/
BOOST_JSON_DECL
~array();
~array() noexcept;

//------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/impl/array.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ array(detail::unchecked_array&& ua)
}

array::
~array()
~array() noexcept
{
destroy();
}
Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/impl/object.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ object(detail::unchecked_object&& uo)
}

object::
~object()
~object() noexcept
{
if(sp_.is_not_shared_and_deallocate_is_trivial())
return;
Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/impl/value.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
BOOST_JSON_NS_BEGIN

value::
~value()
~value() noexcept
{
switch(kind())
{
Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/object.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class object
No-throw guarantee.
*/
BOOST_JSON_DECL
~object();
~object() noexcept;

//------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/storage_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class storage_ptr
@par Exception Safety
No-throw guarantee.
*/
~storage_ptr()
~storage_ptr() noexcept
{
release();
}
Expand Down
2 changes: 1 addition & 1 deletion include/boost/json/string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class string
@par Exception Safety
No-throw guarantee.
*/
~string()
~string() noexcept
{
impl_.destroy(sp_);
}
Expand Down
4 changes: 2 additions & 2 deletions include/boost/json/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class value
No-throw guarantee.
*/
BOOST_JSON_DECL
~value();
~value() noexcept;

/** Default constructor.

Expand Down Expand Up @@ -3426,7 +3426,7 @@ class key_value_pair
The value is destroyed and all internally
allocated memory is freed.
*/
~key_value_pair()
~key_value_pair() noexcept
{
auto const& sp = value_.storage();
if(sp.is_not_shared_and_deallocate_is_trivial())
Expand Down