CMake: Fix conditional compilation of PUML tests #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
puml-tests
branch
from
763c1dd to
73b1a0a
Compare
When `CMAKE_CXX_STANDARD` is not set the LESS condition is not satisfied and the puml tests are still added even if the compiler doesn't support it or it isn't enabled. Check for it being set first. Otherwise add those tests as a separate target if the compiler does support C++20.
Flamefire
force-pushed
the
puml-tests
branch
from
73b1a0a to
40e66bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CMAKE_CXX_STANDARDis not set the LESS condition is not satisfied and the puml tests are still added even if the compiler doesn't support it or it isn't enabled.Check for it being set first.
Otherwise add those tests as a separate target if the compiler does support C++20.