Suppress unused parameter warnings #435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Init && init, base && ) | ||
| Init &&, base && ) | ||
| { | ||
| boost::ignore_unused(executable, cmd_line); |
Collaborator
There was a problem hiding this comment.
Why are you using ignore_unused for some and remove the names for others?
Contributor
Author
There was a problem hiding this comment.
I found this more understandable this way. The name of the argument in Launcher & launcher isn't required but for const filesystem::path &executable it does help in understanding what would be here. Similar for error_code& ec
This allows easily verifying that the signature is correct.
The alternatives are to use either approach consistently which is more code, or commenting out the parameter name instead of removing it.
Collaborator
|
Fixed in 662c0b1 |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.