Skip to content

Conversation

@Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Sep 1, 2016

Fixes following warnings:

In file included from ../../../boost/random.hpp:63:
../../../boost/random/discrete_distribution.hpp:95:60: warning: unused parameter 'average' [-Wunused-parameter]
    static WeightType normalize(WeightType val, WeightType average)
                                                           ^
../../../boost/random/discrete_distribution.hpp:186:66: warning: unused parameter 'weights' [-Wunused-parameter]
    static WeightType try_get_sum(const std::vector<WeightType>& weights)
                                                                 ^

@Romain-Geissler-1A
Copy link
Contributor

Ping.

@jeking3
Copy link
Contributor

jeking3 commented Oct 8, 2017

@swatanabe I made the same changes locally to resolve these warnings; however I didn't comment out the variable name, I just removed the variable name. Easy fix for a couple of warnings...

@Romain-Geissler
Copy link

Ping @swatanabe

@Kojoley
Copy link
Contributor Author

Kojoley commented Nov 20, 2017

It looks like this will never be merged.

@jeking3
Copy link
Contributor

jeking3 commented Nov 21, 2017

@Kojoley We're in the middle of the boost 1.67 release cycle so I wouldn't expect anything to be merged right now.

@Kojoley
Copy link
Contributor Author

Kojoley commented Dec 26, 2017

@swatanabe If the reason of not merging this is because you prefer not commenting argument names but removing them just say me and I will do it.

@swatanabe swatanabe closed this in #32 Jan 3, 2018
@Kojoley Kojoley deleted the fix-unused-parameter-warnings branch January 3, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants