Fix line directives for ifdef and ifndef when default hooks are used #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point in the past the handling for #if and #ifdef diverged. The code that handles emitting a line directive when a conditional section is skipped worked for #if but not ifdef/ifndef. This problem was not observable when the eat_whitespace hooks were used instead of the default_preprocessing hooks, because the former signals skipped newlines through the may_skip_whitespace hook, hiding the problem. Furthermore, the majority of Wave tests use the eat_whitespace hooks, so it wasn't visible there. This change restores ifdef/ifndef to the same section as #if, so any changes to conditional handling will happen uniformly. Also, a test case is added to cover the default hooks and this particular case.
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the past the handling for
#ifand#ifdefdiverged. The code that handles emitting a line directive when a conditional section is skipped worked for#ifbut not#ifdef/#ifndef.This problem was not observable when the
eat_whitespace_hookswere used instead of thedefault_preprocessing_hooks, because the former signals skipped newlines through themay_skip_whitespacehook, hiding the problem. Furthermore, the majority of Wave tests use theeat_whitespacehooks, so it wasn't visible in testing.This change restores
#ifdef/#ifndefto the same section as#if, so any future changes to conditional handling will happen uniformly. Also, a test case is added to cover the default hooks and this particular case.If merged, this will resolve #138