Use only node16 in CI #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To test against different compiler versions we use older Docker images, which in turn have different glibc versions. Github recently deprecated Node version 16, which had been built with an older glibc version, and the newer Node version requires a glibc version that is not available on the old images, causing builds to fail. This is a hack permitting the continued use of Node 16, until Github decides to make it impossible.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test against different compiler versions we use older Docker images, which in turn have different glibc versions. Github recently deprecated Node version 16, which had been built with an older glibc version, and the newer Node version requires a glibc version that is not available on the old images, causing builds to fail.
This is a hack permitting the continued use of Node 16, until Github decides to make it impossible.