This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Expand the github error message - and show the JSON payload if even that... #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM cc @gmlewis |
util.go
Outdated
Contributor
There was a problem hiding this comment.
Hmmm... my opinion is that it is always dangerous to ignore possible errors... I would capture it and return "", err here if ReadAll has problems.
Contributor
|
LGTM after comments addressed. |
SvenDowideit
pushed a commit
that referenced
this pull request
Aug 19, 2014
Expand the github error message - and show the JSON payload if even that...
SvenDowideit
added a commit
to SvenDowideit/boot2docker-cli
that referenced
this pull request
Nov 10, 2014
BUILD: add --rm to docker build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... fails
for boot2docker/boot2docker#481