Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Conversation

@zeeyang
Copy link
Contributor

@zeeyang zeeyang commented Oct 1, 2014

Fusion driver for boot2docker-cli WIP...

@zeeyang zeeyang force-pushed the fusion-bindings branch 2 times, most recently from c12607c to d4b589b Compare October 2, 2014 22:48
@tianon
Copy link
Contributor

tianon commented Oct 9, 2014

Very interesting! 😄

So, since you've self-titled this a WIP, can you elaborate on what bits aren't complete? I'm curious why the driver needs a concept of "hostname", too.

Also, I'm not nearly as familiar with Fusion as I used to be (since I don't use a Mac as my daily driver any more); any chance much of this would be portable to VMware Player or VMware Workstation at some point in the future? 👼

@zeeyang
Copy link
Contributor Author

zeeyang commented Oct 9, 2014

It's 80% there... At this point I could init, boot up with Fusion, start, stop, pause, delete, and ssh.

The current Virtualbox implementation maps SSH and Docker ports to localhost. But Fusion doesn't have a port forwarding API. It would require sudo modify nat.conf. It's cleaner just connect directly to the vm IP - plus it solves the port conflict issue if you run multiple instances of boot2docker vm. It also opens doors to pushing boot2docker to ESX or AWS.

@oliverkurth is putting together a pull request for boot2docker iso to include vmware guest tools. It would probably defer running make_iso.sh to runtime, so we can parametize which guest to include. I'll save that discussion for Oliver's PR.

This driver should work for Workstation on Windows/Linux with a few path tweaks, but I have yet to test it. I'll create a separate PR for it.

@SvenDowideit
Copy link
Contributor

awesome! I might play after 1.3.0's cooked, then i can finally stop running 3 virtualisation tools (I use qemu in consle mode for very fast OS tests)

@bfirsh
Copy link
Contributor

bfirsh commented Oct 28, 2014

@zeeyang Just a heads up: boot2docker-cli will likely be deprecated after the release of host management.

There are examples of host management drivers on my host-management branch. It'd be great to get a VMWare Fusion driver for that.

@SvenDowideit
Copy link
Contributor

@tianon can we merge this please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust these similarly to what was done to VirtualBox in #290 (normalizing the error interfaces a bit, essentially using driver.Err... instead)?

@tianon
Copy link
Contributor

tianon commented Dec 1, 2014

Other than the error handling nit from #290, LGTM.

@tianon
Copy link
Contributor

tianon commented Dec 24, 2014

docker-archive-public/docker.machine#6 is where this is happening for Docker Machine 👍

@tianon
Copy link
Contributor

tianon commented Dec 24, 2014

See also #328 for where @jamtur01 carried this and added the error handling fixes I requested above. 👍

@zeeyang
Copy link
Contributor Author

zeeyang commented Dec 26, 2014

We have a patch for docker machine that are a few fixes ahead. Are there plans to sunset b2d-cli? If not, it's probably best we refactor the fusion bindings to a standalone lib to minimize the duplication between these two drivers.

@jamtur01
Copy link

@zeeyang Can you link to the PR?

@zeeyang
Copy link
Contributor Author

zeeyang commented Dec 26, 2014

@jamtur01
Copy link

I don't mind where they get merged. I suspect b2d will live longer than expected as is the way of these things. I just want the functionality and wanted to push this ahead.

@SvenDowideit
Copy link
Contributor

@zeeyang if we can refactor the b2d driver interface to use the docker machine one, then we're hedging and can test the code out in b2d releases :)

@SvenDowideit SvenDowideit added this to the 1.5.0 milestone Jan 4, 2015
@SvenDowideit
Copy link
Contributor

ok, I've played with this a little, and its mostly working, so I'm going ot merge

LGTM

SvenDowideit added a commit that referenced this pull request Jan 4, 2015
Add Fusion driver and vmx template
@SvenDowideit SvenDowideit merged commit 63ff5c8 into boot2docker:master Jan 4, 2015
@tianon
Copy link
Contributor

tianon commented Jan 5, 2015

...

@tianon
Copy link
Contributor

tianon commented Jan 5, 2015

Care to elaborate more on what "mostly working" means? I'm specifically interested in what isn't working, and would rather not merge things that aren't user-ready.

@SvenDowideit
Copy link
Contributor

@tianon see the other 2 PR's - @jamtur01 resolved the error handling, and then in my new PR, I've made it work with the existing b2d.iso (ie, without needing the vmware tools)

I have noticed an intermittent issue with deleting - once the vmware gui gets involved, but otherwise, its been seriously solid.

@tianon
Copy link
Contributor

tianon commented Jan 8, 2015

Ok, that's more fair, but doesn't explain why it was necessary or appropriate to merge this one, which has none of those improvements.

@SvenDowideit
Copy link
Contributor

pretty simple - your LGTM from #265 (comment) plus my having tested it, and both @jamtur01 and I having follow on PR's meant that I could this and then get on with my work actually using it.

with machine hanging and crashing on my system, I'm looking for a non-pre-beta way to use existing TLS and non-TLS b2d iso's with fusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants