-
Notifications
You must be signed in to change notification settings - Fork 93
Update default ISO path to prefer an ISO that's next to the boot2docker CLI binary #283
Conversation
config.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should be doing an EvalSymlinks on this os.Args[0] first so that we can have this work for OS X too (without putting the ISO in /usr/local/bin or similar).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna update with EvalSymlinks logic.
|
When they run boot2docker.app, it puts it in the right place, doesn't it? Can't the installer do this? |
…er CLI binary This is especially important for places like the Windows installer, where we want people to be able to install boot2docker 1.3 from an installer, and it includes the right ISO, so when they boot their VM, it should also be boot2docker 1.3, without any extra work or extra downloading.
106a06a to
6220822
Compare
|
Updated with much more correct logic. @bfirsh technically, the |
|
(unless I do an explicit |
|
Anyone else want to weigh in? :) |
|
C'mon you 27 members of the peanut gallery watching this repo, surely some of you have opinions on this; let's have 'em! 😉 |
|
My $0.02 - I don't like programs to dictate where I put my executables... and I certainly don't want an ISO where I put the executable. |
|
Right, this isn't really dictating that. This is essentially just a bonus feature for if you happen to put your executable next to an ISO you want to use, like the Windows installer does. Everyone else will probably put it in Essentially, what we're dictating with this change is that if you install with the installers, you can update with the installers and actually have stuff update properly. |
|
OK, in that case, LGTM. |
|
It makes a lot of sense to me, and is certainly a convenience. |
|
yes, this needs documentation, and i might have a tweak for osx - I'll make an update PR when i've finished testing |
Linux
Windows
OSX
|
|
and so LGTM, with a followup PR coming |
Update default ISO path to prefer an ISO that's next to the boot2docker CLI binary
This is especially important for places like the Windows installer, where we want people to be able to install boot2docker 1.3 from an installer, and it includes the right ISO, so when they boot their VM, it should also be boot2docker 1.3, without any extra work or extra downloading.