Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Conversation

@tianon
Copy link
Contributor

@tianon tianon commented Oct 15, 2014

This is especially important for places like the Windows installer, where we want people to be able to install boot2docker 1.3 from an installer, and it includes the right ISO, so when they boot their VM, it should also be boot2docker 1.3, without any extra work or extra downloading.

config.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should be doing an EvalSymlinks on this os.Args[0] first so that we can have this work for OS X too (without putting the ISO in /usr/local/bin or similar).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna update with EvalSymlinks logic.

@tianon tianon modified the milestone: 1.3.0 Oct 15, 2014
@bfirsh
Copy link
Contributor

bfirsh commented Oct 15, 2014

When they run boot2docker.app, it puts it in the right place, doesn't it? Can't the installer do this?

…er CLI binary

This is especially important for places like the Windows installer, where we want people to be able to install boot2docker 1.3 from an installer, and it includes the right ISO, so when they boot their VM, it should also be boot2docker 1.3, without any extra work or extra downloading.
@tianon
Copy link
Contributor Author

tianon commented Oct 15, 2014

Updated with much more correct logic.

@bfirsh technically, the start.sh script could copy it over for Windows, but I really think both of those are hacky - if I explicitly install Boot2Docker 1.3, then boot2docker up should boot Boot2Docker 1.3 for me, IMO

@tianon
Copy link
Contributor Author

tianon commented Oct 15, 2014

(unless I do an explicit boot2docker --iso=some-other-iso up)

@tianon
Copy link
Contributor Author

tianon commented Oct 15, 2014

Anyone else want to weigh in? :)

@tianon
Copy link
Contributor Author

tianon commented Oct 15, 2014

C'mon you 27 members of the peanut gallery watching this repo, surely some of you have opinions on this; let's have 'em! 😉

@gmlewis
Copy link
Contributor

gmlewis commented Oct 15, 2014

My $0.02 - I don't like programs to dictate where I put my executables... and I certainly don't want an ISO where I put the executable.

@tianon
Copy link
Contributor Author

tianon commented Oct 15, 2014

Right, this isn't really dictating that. This is essentially just a bonus feature for if you happen to put your executable next to an ISO you want to use, like the Windows installer does. Everyone else will probably put it in /usr/local/bin or ~/bin and thus never run into this (and thus the default for them will stay ~/.boot2docker/boot2docker.iso and require using boot2docker download etc).

Essentially, what we're dictating with this change is that if you install with the installers, you can update with the installers and actually have stuff update properly.

@gmlewis
Copy link
Contributor

gmlewis commented Oct 15, 2014

OK, in that case, LGTM.

@daghack
Copy link
Contributor

daghack commented Oct 15, 2014

It makes a lot of sense to me, and is certainly a convenience.

@SvenDowideit
Copy link
Contributor

yes, this needs documentation, and i might have a tweak for osx - I'll make an update PR when i've finished testing

@SvenDowideit
Copy link
Contributor

Linux

  • if you only have a ~/.boot2docker/boot2docker.iso is works the same as always
  • you can optionally throw your iso into /usr/local/bin/boot2docker.iso assuming thats where you throw your cli binary, and all users will use that iso instead.

Windows

  • if you have an existing iso in ~/.boot2docker/ it will be used on your existing vm until you delete it (during which time, the cli help will lie to you, but b2d info will tell you the truth), after that, by default, it'll use the iso in C:/Progra...
  • new users will have it always use the shared iso, and will need to set flags, or profile file to change it.

OSX

  • essentially the same as Linux

@SvenDowideit
Copy link
Contributor

and so LGTM, with a followup PR coming

SvenDowideit added a commit that referenced this pull request Oct 16, 2014
Update default ISO path to prefer an ISO that's next to the boot2docker CLI binary
@SvenDowideit SvenDowideit merged commit b9082bc into boot2docker:master Oct 16, 2014
@tianon tianon deleted the boot2docker.iso branch December 16, 2014 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants