Fusion doesnt need vmware os addons #331
Conversation
|
You've taken all my changes so it's moot. LGTM |
|
I'm working on a new lib that's meant to consolidate the effort around fusion/workstation. The goal is to have much better error handling and logging baked into the lib layer. https://github.com/zeeyang/fusia Getting ip from dhcp lease table as a fall back is one of the things I'm planning on putting in the fusia lib, but it should also check if the NIC is |
|
@zeeyang oh, with pleasure! |
|
@jamtur01 grrr, you mean you're forcing me to rebase your changes? thats mean! |
|
mmm, intersting. the vmware dhcp server is sending an invalid nameserver when you add a second host only network. |
|
actually, @zeeyang @tianon can we merge this as its useful today, and then move over to your new code when its ready? the UX should be the same. There are quite alot of people that would like to work with fusion, and having code that gets tested is useful - I've found (and made a PR) an issue in the iso already :) |
Also updated to support the error changes in boot2docker#290. Uses the code started by the excellent Zee Yang (https://github.com/zeeyang) Signed-off-by: James Turnbull <james@lovedthanlost.net>
…P using dhcp server lease files Signed-off-by: Sven Dowideit <SvenDowideit@docker.com>
SvenDowideit
force-pushed
the
fusion-doesnt-need-vmware-os-addons
branch
from
1dd7613 to
2e12861
Compare
|
Closing as #333 makes it clear b2d-cli is already in stasis. |
3 participants
replaces @jamtur01 and @zeeyang 's PR's
I've added code to get the first network device's IP address from the isc dhcpd's log files - now you don't need to have the vmware tools installed in the OS for it to work. (it tries the vmware tools first)
I've added the second eth device - the host only one to the vmx
@jamtur01 if you re-do your PR to separate your changes from @zeeyang 's, then I will rejig based on that, as I don't really feel thrilled about his work being subsumed into your commit.